pmm: simpler and bugfix process_memory_range loop #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
requested changes
Feb 16, 2024
sktt
force-pushed
the
pmm-loop
branch
3 times, most recently
from
4850686
to
2c43bd7
Compare
This simplifies the adding of frames during boot. It also fixes a bug for configurations with > 1GB memory. After the initial 4K frames, the current (`cur`) is aligned to 2MB. Trying to add a 1GB frame at this point will lead to page faults further down the line as we end up with misaligned page frame mfns. Signed-off-by: Johannes Wikner <[email protected]>
Previously used but with the current pmm loop, there's no need for it. Signed-off-by: Johannes Wikner <[email protected]>
wipawel
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the adding of frames during boot. It also fixes a bug for configurations with > 1GB memory. After the initial 4K frames, the current (
cur) is aligned to 2MB. Trying to add a 1GB frame at this point will lead to page faults further down the line as we end up with misaligned page frame mfns.I am pretty unsure about what I did to the
index <= first_avail_region(completely dropped it). Let me know if this should be included still somehow.