fix(v3.2.55): start.bat を pure ASCII 化 — cmd.exe parse エラー修正 - #211
Merged
Merged
Conversation
## 問題 v3.2.42 で追加した start.bat は UTF-8 (BOM なし) で保存され、日本語コメント: ```batch rem PowerShell 7 (pwsh) を優先。PATH 不通でも既知インストール先を検査する。 ``` を含んでいた。Windows 日本語ロケールの cmd.exe は .bat を CP932 (Shift-JIS) で 解釈するため、UTF-8 の「を」「優先」等のバイト列を mis-decode し、その結果 後続の if 節で「not was unexpected at this time.」エラー (exit 255) が発生。 ## 修正 日本語コメントを英語に置換し、pure ASCII 化: ```batch rem Prefer PowerShell 7 (pwsh). Check known install paths when PATH lookup fails. ``` ## 検証 - ASCII only 確認: `[regex]::IsMatch(text, '[^\x00-\x7F]')` が false - cmd.exe による parse 通過 (エラー出力なし) ## 教訓 .bat は cmd.exe のロケール依存なので日本語コメント入れ禁止とする。メッセージを 日本語出したい場合は `chcp 65001` 後に PowerShell から `Write-Host` する。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
📝 WalkthroughWalkthrough
Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows cmd.exe parsing failure on CP932 locales by replacing a previously Japanese rem comment in start.bat with an English, pure-ASCII comment, avoiding mojibake that could lead to not was unexpected at this time. errors.
Changes:
- Replace the Japanese comment in
start.batwith an English ASCII-only comment to prevent CP932 mis-decoding issues.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.2.42 で追加した日本語コメントが CP932 ロケール cmd.exe で mis-decode され、'not was unexpected at this time.' exit 255 エラーが発生していた。英語コメントに置換し pure ASCII 化して解消。
Summary by CodeRabbit
リリースノート
このリリースには、エンドユーザーに対する機能変更や改善はありません。