Merge pull request #32 from Keloran/update-local-secrets-function

refactor: Remove LocalSecretsPath from Details struct and update corresponding methods

vault.go

@@ -68,7 +68,6 @@ type Vault struct {
 type Details struct {
   CredPath string `env:"VAULT_CRED_PATH" envDefault:"secret/data/chewedfeed/creds"`
   DetailsPath string `env:"VAULT_DETAILS_PATH" envDefault:"secret/data/chewedfeed/details"`
-  LocalSecretsPath string `env:"VAULT_LOCAL_SECRETS_PATH" envDefault:"/secrets"`
 
   ExpireTime time.Time
 }
@@ -94,6 +93,14 @@ func NewVault(address, token string) *Vault {
 	}
 }
 
+func (v *Vault) GetSecrets(path string) error {
+  if strings.HasPrefix(path, ".") || strings.HasPrefix(path, "/") {
+    return v.GetLocalSecrets(path)
+  }
+
+  return v.GetRemoteSecrets(path)
+}
+
 func (v *Vault) GetLocalSecrets(path string) error {
   if path == "" {
     return logs.Local().Errorf("path: %s, err: %s", path, "no path provided")

vault_test.go

@@ -7,6 +7,50 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func TestLocalSecrets(t *testing.T) {
+  mockLogical := &MockLogical{
+		MockRead: func(path string) (*api.Secret, error) {
+			// Return a mock Secret for testing purposes
+			return &api.Secret{
+				Data: map[string]interface{}{
+					"keycloak-realm": "test-realm",
+				},
+			}, nil
+		},
+	}
+
+	mockClient := &MockVaultClient{
+		MockLogical: func() LogicalClient {
+			return mockLogical
+		},
+		MockSetToken: func(token string) {
+			// Do nothing or validate the token
+		},
+	}
+
+	v := &Vault{
+		Client:  mockClient,
+		Address: "mockaddress",
+		Token:   "mocktoken",
+	}
+
+  // Test path secret
+  err := v.GetSecrets("./test_data.json")
+  assert.Nil(t, err)
+
+  localSecret, err := v.GetSecret("keycloak-realm")
+  assert.Nil(t, err)
+  assert.Equal(t, "test_realm", localSecret)
+
+  // test remote
+  err = v.GetSecrets("mockpath")
+  assert.Nil(t, err)
+
+  remoteSecret, err := v.GetSecret("keycloak-realm")
+  assert.Nil(t, err)
+  assert.Equal(t, "test-realm", remoteSecret)
+}
+
 func TestParseJSON(t *testing.T) {
   v := &Vault{}
 
@@ -33,7 +77,7 @@ func TestParseDATA(t *testing.T) {
   assert.Equal(t, "test_secret", secret)
 }
 
-func TestGetSecrets(t *testing.T) {
+func TestGetRemoteSecrets(t *testing.T) {
 	mockLogical := &MockLogical{
 		MockRead: func(path string) (*api.Secret, error) {
 			// Return a mock Secret for testing purposes