Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make codecov checks non-failing #3346

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

FliegendeWurst
Copy link
Member

Insufficient test coverage shouldn't lead to a red X in the PR list. The ❌ should be reserved for more urgent problems (formatting / compilation / failing tests) that actually block merging.

Docs for codecov.yml: https://docs.codecov.com/docs/commit-status

@FliegendeWurst FliegendeWurst added github_actions Pull requests that update GitHub Actions code Ignore in Changelog If given, a PR will not be considered for Changelog generation. Use this on unimportant stuff. labels Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ab2555) 37.86% compared to head (0de9765) 37.86%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3346   +/-   ##
=========================================
  Coverage     37.86%   37.86%           
+ Complexity    16904    16903    -1     
=========================================
  Files          2055     2055           
  Lines        125528   125528           
  Branches      21226    21226           
=========================================
+ Hits          47525    47526    +1     
  Misses        72152    72152           
+ Partials       5851     5850    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unp1
Copy link
Member

unp1 commented Nov 13, 2023

Is it possible to just raise the percentage bar from which on a red cross is used. Setting it to 0.5 % or 1% would get rid of all the usual ones, but still highlight more severe losses of coverage?

@Drodt
Copy link
Member

Drodt commented Nov 13, 2023

Is it possible to just raise the percentage bar from which on a red cross is used. Setting it to 0.5 % or 1% would get rid of all the usual ones, but still highlight more severe losses of coverage?

There is a threshold option, which should work for our case: https://docs.codecov.com/docs/github-3-customizing-codecov

@FliegendeWurst
Copy link
Member Author

FliegendeWurst commented Nov 13, 2023

There is a threshold option, which should work for our case: docs.codecov.com/docs/github-3-customizing-codecov

Good idea. I think target: 38% and threshold: 1% would work well. When the test coverage increases significantly, the target should be increased as well.

@wadoon wadoon self-requested a review November 18, 2023 18:17
@wadoon wadoon enabled auto-merge November 18, 2023 18:19
@wadoon wadoon added this pull request to the merge queue Nov 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 18, 2023
@unp1 unp1 enabled auto-merge November 18, 2023 20:29
@FliegendeWurst
Copy link
Member Author

Hold up, I didn't change it to 38% +- 1 yet. But that can be done in a follow-up PR if it's desired ..

Insufficient test coverage shouldn't lead to a red X
@wadoon wadoon force-pushed the codecov-informational branch from 46a9766 to 0de9765 Compare November 19, 2023 22:33
@unp1 unp1 added this pull request to the merge queue Nov 19, 2023
Merged via the queue into KeYProject:main with commit 1e5e4cc Nov 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code Ignore in Changelog If given, a PR will not be considered for Changelog generation. Use this on unimportant stuff.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants