-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: make codecov checks non-failing #3346
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3346 +/- ##
=========================================
Coverage 37.86% 37.86%
+ Complexity 16904 16903 -1
=========================================
Files 2055 2055
Lines 125528 125528
Branches 21226 21226
=========================================
+ Hits 47525 47526 +1
Misses 72152 72152
+ Partials 5851 5850 -1 ☔ View full report in Codecov by Sentry. |
Is it possible to just raise the percentage bar from which on a red cross is used. Setting it to 0.5 % or 1% would get rid of all the usual ones, but still highlight more severe losses of coverage? |
There is a |
Good idea. I think target: 38% and threshold: 1% would work well. When the test coverage increases significantly, the target should be increased as well. |
Hold up, I didn't change it to 38% +- 1 yet. But that can be done in a follow-up PR if it's desired .. |
Insufficient test coverage shouldn't lead to a red X
46a9766
to
0de9765
Compare
Insufficient test coverage shouldn't lead to a red X in the PR list. The ❌ should be reserved for more urgent problems (formatting / compilation / failing tests) that actually block merging.
Docs for codecov.yml: https://docs.codecov.com/docs/commit-status