Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

更新代码 #2

Merged
merged 8 commits into from
Oct 12, 2020
Merged

更新代码 #2

merged 8 commits into from
Oct 12, 2020

Conversation

KeRan213539
Copy link
Owner

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Maijh97 and others added 8 commits September 21, 2020 15:18
@Maijh97
bug: fix the problem of incorrect judgment of http response code in S…
4ce897e 
…ubscribeManager#getSubscribers() method (#3879)
@horizonzy
[ISSUE #3867] replace the way which get version (#3872)
f01cd59 
* replace the way which get version

* remove version sign application.properties in nacos-api
@shizhengxing
[ISSUE #3871] fix description don't match the error (#3886)
5df146e
@ljhrot
Fix chinese string are truncated in ConcunrrentDiskUtil (#3883)
7902b22
@binbin0325 @yanlinly @KomachiSion
update spring boot dependencies version (#3900)
e2c037d 
Co-authored-by: yanlinly <[email protected]>
Co-authored-by: 杨翊 SionYang <[email protected]>
@binbin0325 @yanlinly @KomachiSion
[ISSUE #3781]Fix service list intermittently lost service (#3891)
787ea47 
* update service init

* commit futureMap.remove()

* update serviceManager

Co-authored-by: yanlinly <[email protected]>
Co-authored-by: 杨翊 SionYang <[email protected]>
@horizonzy
[ISSUE #3850] ignore socket exception when client destroy already (#3906
f6c6a9f 
)

* if client destroy already, ignore socket exception.

* remove the exception's judgement

* remove unuseful import
@horizonzy
isAddressServerHealth set as true when request success (#3952)
5745922
@KeRan213539 KeRan213539 merged commit 5fe766a into KeRan213539:develop Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KeRan213539 @Maijh97 @horizonzy @shizhengxing @ljhrot @binbin0325