Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Jaeger to avoid errors related to opentracing/opentelemetry #291

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Oct 18, 2024

Closes #290

@zakkak zakkak requested a review from Karm October 18, 2024 12:11
@Karm
Copy link
Owner

Karm commented Oct 21, 2024

Hello @zakkak, we haven't had Jaeger there historically and we used to whitelist the connection error:

https://github.com/Karm/mandrel-integration-tests/blob/master/testsuite/src/it/java/org/graalvm/tests/integration/utils/WhitelistLogLines.java#L118

If I remember correctly, it was to avoid friction with handling yet another runtime source of entropy for the testsuite. It was also way before the time the container control flow and "cleaning" containers was introduced. So perhaps it could be fine now?

Thx 🙏 🙏

@zakkak
Copy link
Collaborator Author

zakkak commented Oct 29, 2024

Hi @Karm any updates on this?

Copy link
Owner

@Karm Karm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak

Linux, aarch64, Podman:

First running:

$ mvn  clean verify -Ptestsuite -DexcludeTags=all -DincludeTags=perfcheck,reproducers -Dtest=PerfCheckTest#testQuarkusFullMicroProfile -Dquarkus.version=3.16.0

And then running:

$  mvn clean verify -Ptestsuite -Dtest=RuntimesSmokeTest#quarkusFullMicroProfile -Dquarkus.version=3.16.0 -Dquarkus.native.container-runtime=podman -Dpodman.with.sudo=false

gives:

Error: creating container storage: the container name "quarkus_jaeger" is already in use by b745adcccf87008e79f4d572b28320ddcdfa06968a8e43f63496fa44457270e1. You have to remove that container to be able to reuse that name: that name is already in use, or use --replace to instruct Podman to do so.

re-running

$  mvn clean verify -Ptestsuite -Dtest=RuntimesSmokeTest#quarkusFullMicroProfile -Dquarkus.version=3.16.0 -Dquarkus.native.container-runtime=podman -Dpodman.with.sudo=false

Makes it all right, so IMHO the PerfCheck is just missing cleanup in finally?

Mac

karm@mandrel-macos-aarch64-2 mandrel-integration-tests % mvn clean verify -Ptestsuite -Dtest=RuntimesSmokeTest#quarkusFullMicroProfile -Dquarkus.version=3.16.0 -Dquarkus.native.container-runtime=podman -Dpodman.with.sudo=false

Works fine (with jaeger from Quay)

Docker Hub

Dependency on dockerhub is IMHO a no-no, it will keep randomly collapsing on CI due to free tier rate limiting. Does not show on my laptop wit Docker account but it does on random servers:

Error: initializing source docker://jaegertracing/all-in-one:latest: reading manifest latest in docker.io/jaegertracing/all-in-one: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

Please, either find trustworthy jaeger on Quay or package our own since we really don't care about it being up to date in this scenario. We don't hit this issue with e.g. hyperfoil as we use https://quay.io/repository/karmkarm/hyperfoil. Databases are also used from Quay...

e.g jaegertracing/jaeger#2783

so quay.io/jaegertracing/all-in-one works for me 👍

TL;DR:

  • pls add cleanup in PerfCheck test
  • pls use Quay

@zakkak zakkak force-pushed the 2024-10-18-setup-jaeger-for-tracing branch from e9eeb77 to 0811c8d Compare October 29, 2024 18:27
@zakkak
Copy link
Collaborator Author

zakkak commented Oct 29, 2024

pls add cleanup in PerfCheck test
pls use Quay

Done

Copy link
Owner

@Karm Karm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

@Karm Karm merged commit a2afef3 into Karm:master Oct 29, 2024
27 checks passed
@zakkak zakkak deleted the 2024-10-18-setup-jaeger-for-tracing branch October 30, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEVERE error in integration tests due to update of OpenTelemetry
2 participants