-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start Jaeger to avoid errors related to opentracing/opentelemetry #291
Conversation
Hello @zakkak, we haven't had Jaeger there historically and we used to whitelist the connection error: If I remember correctly, it was to avoid friction with handling yet another runtime source of entropy for the testsuite. It was also way before the time the container control flow and "cleaning" containers was introduced. So perhaps it could be fine now?
Thx 🙏 🙏 |
Hi @Karm any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux, aarch64, Podman:
First running:
$ mvn clean verify -Ptestsuite -DexcludeTags=all -DincludeTags=perfcheck,reproducers -Dtest=PerfCheckTest#testQuarkusFullMicroProfile -Dquarkus.version=3.16.0
And then running:
$ mvn clean verify -Ptestsuite -Dtest=RuntimesSmokeTest#quarkusFullMicroProfile -Dquarkus.version=3.16.0 -Dquarkus.native.container-runtime=podman -Dpodman.with.sudo=false
gives:
Error: creating container storage: the container name "quarkus_jaeger" is already in use by b745adcccf87008e79f4d572b28320ddcdfa06968a8e43f63496fa44457270e1. You have to remove that container to be able to reuse that name: that name is already in use, or use --replace to instruct Podman to do so.
re-running
$ mvn clean verify -Ptestsuite -Dtest=RuntimesSmokeTest#quarkusFullMicroProfile -Dquarkus.version=3.16.0 -Dquarkus.native.container-runtime=podman -Dpodman.with.sudo=false
Makes it all right, so IMHO the PerfCheck is just missing cleanup in finally?
Mac
karm@mandrel-macos-aarch64-2 mandrel-integration-tests % mvn clean verify -Ptestsuite -Dtest=RuntimesSmokeTest#quarkusFullMicroProfile -Dquarkus.version=3.16.0 -Dquarkus.native.container-runtime=podman -Dpodman.with.sudo=false
Works fine (with jaeger from Quay)
Docker Hub
Dependency on dockerhub is IMHO a no-no, it will keep randomly collapsing on CI due to free tier rate limiting. Does not show on my laptop wit Docker account but it does on random servers:
Error: initializing source docker://jaegertracing/all-in-one:latest: reading manifest latest in docker.io/jaegertracing/all-in-one: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Please, either find trustworthy jaeger on Quay or package our own since we really don't care about it being up to date in this scenario. We don't hit this issue with e.g. hyperfoil as we use https://quay.io/repository/karmkarm/hyperfoil. Databases are also used from Quay...
so quay.io/jaegertracing/all-in-one
works for me 👍
TL;DR:
- pls add cleanup in PerfCheck test
- pls use Quay
e9eeb77
to
0811c8d
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx.
Closes #290