Rename #3
Merged
Rename #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ListAnomaliesForAlertConfigurationOptions` property `dimensionFilter` to `seriesGroupKeys` - `ListFeedbackOptions` property `dimensionFilter` to `seriesKey` - `ListIncidentsForDetectionConfigurationOptions` property `dimensionFilter` to `seriesGroupKeys` - `MetricEnrichedSeriesData` property `series` to `seriesKey` - `MetricSeriesDefinition` property `dimension` to `seriesKey`
KarishmaGhiya
approved these changes
Jun 18, 2021
KarishmaGhiya
pushed a commit
that referenced
this pull request
Jan 30, 2023
* initial changes stableversion * old files modified * Added polling Helper * Added initial sample and tests * Added API Review * Added samples for JS and TS * pnpm lock file and Readme Update * Added test and removed locale from readme * Corrected broken links * Added dev-tool and eslint * formatting changes * Added Browser Recordings * Code generated from main API * Added Test Recordings * Added Samples for JS and TS * Added Validation Poller * added champion scenario in single file * added stop and delete samples * Update sdk/loadtestservice/load-testing-rest/package.json Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * added TestRun LRO * modified upload and validte LRO * Single Test File for test and testrun * Samples and LRO changes * Create Test in LRO removed from sample * Update sdk/loadtestservice/load-testing-rest/src/beginCreateOrUpdateTestRun.ts Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * Update sdk/loadtestservice/load-testing-rest/src/beginUploadTestFile.ts Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * Samples and LRO changes as per review * Added timeout in samples and test recordings * New Samples generated and corrected broken link * Update sdk/loadtestservice/load-testing-rest/samples-dev/stopTest.ts Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * Update sdk/loadtestservice/load-testing-rest/samples-dev/stopTest.ts Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * Update sdk/loadtestservice/load-testing-rest/src/beginUploadTestFile.ts Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * Added Sleep Utility * Updated Readme * Updated Changelog * Updated LRO to take queryparams * Added Tests for LRO impl * Generated latest Samples * GetLROHelper Similar impl * Review Comment Changes * Updated imports * LRO error condtions corrected * Added AbortSignal Changes * Added LRO Tests * Removed Begin Methods and added new recordings for tests * Corrected Broken Links * rush file update * build failure due to core-http formatting * LRO Helper Changes Done * Ran API extractor again * Running empty tests * Review Comments LRO Helper * New API review * LRO helper refactoring * Updated Samples and Readme * Throw Error when Abort * Updated Sample * Updated API View * Updated package.json, Readme and Samples * Updated Release date and core-client version * Updated @azure/abort-controller version * Update sdk/loadtestservice/load-testing-rest/package.json Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.