Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Polishing #413

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Misc Polishing #413

merged 6 commits into from
Jul 21, 2021

Conversation

majora2007
Copy link
Member

@majora2007 majora2007 commented Jul 21, 2021 •
edited
Loading

Fixed

  • Fixed: After adding a role to a user, ensure the screen updates immediately

Changed

  • Changed: Fetching LibraryType API is now cached in the browser to speed up visits to series detail

Code only Changes

  • Refactored Configuration to use getter and setters to have a very clean interface for interacting with the underlying appsettings.json
  • Cleaned up a ton of TODOs in the Frontend
  • Remove the debug code that Chris is testing with

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@majora2007 majora2007 merged commit b8165b3 into develop Jul 21, 2021
@majora2007 majora2007 deleted the feature/misc-polishing branch July 21, 2021 02:39
This was referenced Jul 21, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@majora2007