Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Series detail spacing issue while keeping a restriction on height for webbtoons #412

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Fixed: Series detail spacing issue while keeping a restriction on height for webbtoons #412

merged 1 commit into from
Jul 21, 2021

Conversation

therobbiedavis
Copy link
Collaborator

@therobbiedavis therobbiedavis commented Jul 21, 2021 •
edited by majora2007
Loading

Fixed:

  • Fixed: When the series detail thumbnail was too long it would push down the Volumes/Specials selection.

Changed:

  • Modified: increased the max-height to incorporate a percentage width for responsive scaling.

@therobbiedavis
Fixing up a sizing issue while keeping a restriction on height for we…
09bdd45 
…btoons

- increased the max-height to incorporate a percentage width for responsive scaling.
- Removed image-centering. No longer needed.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

majora2007
majora2007 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@majora2007 majora2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as expected.

@majora2007 majora2007 merged commit ef5b22b into develop Jul 21, 2021
@majora2007 majora2007 deleted the bugfix/poster-image-spacing branch July 21, 2021 01:36
This was referenced Jul 21, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majora2007 majora2007 majora2007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therobbiedavis @majora2007