More Webtoon Fixes #406
Merged
More Webtoon Fixes #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ChapterId for lookup, not MangaFile.Id). Refactored how downloading works on the UI side to use the backend's filename whenever possible, else provide a custom name (and use backend's extension) for bundled downloads.
… a table of content, even though it should have.
… the url, allow authentication, then redirect them to said url
…es) where bookmark progress can duplicate
… into it's own, dedicated handler to simplify logic.
…nfinite scroller changes. This results in an easier to understand functioning.
…ion based on the delta.
… separate functions to prepare for a rewrite.
…lves. It is not fully tested, but working much better than previous implementation. Will be enhanced with DOM Pruning.
…ill handle the correct prefetching of next/prev chapter
…ot, which works better than max/min in cases where you jump to a page that doesn't have anything preloaded and loads images out of order
…ode will now redirect to the original location you requested before you had to login.
… not work on intersection observer. using 0.01 instead of 0.0.
…on if the users scrolls up and down when near the last page, due to a gap in checking if prefetch range is within totalPages bound.
…abled reading direction when in webtoon reader.
…ature/webtoon-reader-fixup
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some more issues noted in #392.
This PR also added DOM pruning via *ngIf that seems to work pretty well on mobile devices to reduce page jank