Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapter and issue parsing for comics #343

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

therobbiedavis
Copy link
Collaborator

@therobbiedavis therobbiedavis commented Jun 27, 2021

This adds correct parsing for comic series, volume (0) and chapters in this format:
"Amazing Man Comics c[hapter] 00"
"Amazing Man Comics i[ssue] #00"

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@majora2007
Copy link
Member

Either create an issue with enhancement label and assign to 0.4.2 or tag this PR as enhancement, assign to 0.4.2 and update description with more concrete information (look at my PR for example)

@therobbiedavis
Copy link
Collaborator Author

Closes #344

@majora2007 majora2007 merged commit f18285d into develop Jun 27, 2021
@majora2007 majora2007 deleted the feature/additional-regex-comics branch June 27, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants