Skip to content

fix: improve error handling - #3325

Closed
saurabhhhcodes wants to merge 1 commit into
Karanjot786:mainfrom
saurabhhhcodes:fix/termui-72209
Closed

saurabhhhcodes wants to merge 1 commit into
Karanjot786:mainfrom
saurabhhhcodes:fix/termui-72209

Conversation

@saurabhhhcodes

@saurabhhhcodes saurabhhhcodes commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved keyboard tab switching by ensuring numeric key presses are interpreted consistently as decimal values.

@github-actions github-actions Bot added type:bug +10 pts. Bug fix. area:examples Example apps. and removed type:bug +10 pts. Bug fix. labels Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e7c59522-f699-4f5d-a260-f978000333cb

📥 Commits

Reviewing files that changed from the base of the PR and between 48f63a1 and 5453df1.

📒 Files selected for processing (1)
  • examples/widget-gallery/src/index.ts

📝 Walkthrough

Walkthrough

The widget gallery’s handleKey function now parses numeric tab shortcut keys explicitly as base 10.

Changes

Widget gallery tab navigation

Layer / File(s) Summary
Explicit radix for tab shortcuts
examples/widget-gallery/src/index.ts
handleKey now calls parseInt with radix 10 when converting key input to a tab index.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: type:bug, area:examples

Suggested reviewers: karanjot786

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions error handling, but the change only forces base-10 parsing for tab switching keys. Rename it to reflect the actual change, e.g. "fix: parse tab keys as base-10 in widget gallery".
Description check ⚠️ Warning No PR description was provided, so the required template sections are missing. Add the template sections: Description, Related Issue, Which package(s), Type of Change, Checklist, and any reviewer notes.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the type:bug +10 pts. Bug fix. label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:examples Example apps. type:bug +10 pts. Bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant