Skip to content

Conversation

tslamic
Copy link

@tslamic tslamic commented May 23, 2015

Hi guys,

I believe creating new layout params in the updateBackground() is redundant.

I was also tempted to change

params.setMargins(0, 0, -mMarginDp, 0);
params.setMargins(0, 0, 0, -mMarginDp);

to

params.rightMargin = -mMarginDp;
params.bottomMargin = -mMarginDp;

but I'm not sure if setting other margins to 0 was done on purpose. If not, maybe this shouldn't be reset to 0, since the user might have set the margins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant