Extent OS version with Name and Variant #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2017 14:49
Because the __cmp__ function was implemented with string cmp it would mean that 3.9.0 would be > than 3.10.0.
Ealdwulf
reviewed
Feb 22, 2017
|
|
||
| try: | ||
| self._major_version = '.'.join(version.split('.')[0:2]) | ||
| except: | ||
| self._major_version = version | ||
|
|
||
| def to_issue(self): | ||
| return "{} {} {} \\l".format(self._os, self._codename, self._number) |
There was a problem hiding this comment.
Can this be called on old version files? Since it's in the updater.
Maybe it would be more robust to keep this additional information in a separate file, and not change the format of the existing file.
radujipa
commented
Feb 22, 2017
kano_updater/os_version.py
Outdated
| return "{} {} {} \\l".format(self._os, self._codename, self._number) | ||
| vstr = "{} {} {}".format(self._os, self._devstage, self._number) | ||
| # Add the name and variant to the string only if they exist. | ||
| vstr += ' ' + self._name if self._name else '' |
There was a problem hiding this comment.
@Ealdwulf To your point from above, yes the function can be called on the old file, hence why here I append an empty string when the name cannot be found.
I was careful to preserve backwards compatibility here.
There was a problem hiding this comment.
Ah, you're doing it there. Okay :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://trello.com/c/8HLyQFpt/87-add-tracking-event-that-lets-us-know-a-kit-is-in-argentina
This one needs careful reviewing @tombettany @Ealdwulf @skarbat