Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CJK Radicals Supplement ⺢ #429

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Feb 17, 2024

  • Add CJK Radicals Supplement ⺢
    I copied the file from 06c3a.svg and only changed the kvg:element and the hexcode-formatted Unicode characters.
  • Update kvg-index.json

@benkasminbullock benkasminbullock merged commit cd8005b into KanjiVG:master Feb 18, 2024
@nix6839 nix6839 deleted the add-02ea2 branch February 18, 2024 01:40
@benkasminbullock
Copy link
Member

Thank you for this commit. It looks OK. There was also an error in the Perl script which creates the index file where it skipped past the "0". If you want to check the formatting of your input there is also a repository https://github.com/benkasminbullock/kvg which contains a subdirectory "cmd" where there is read-write-test.go which reads and writes the repository to check the formatting is OK.

@nix6839
Copy link
Contributor Author

nix6839 commented Feb 18, 2024

Thank you for this commit. It looks OK. There was also an error in the Perl script which creates the index file where it skipped past the "0". If you want to check the formatting of your input there is also a repository benkasminbullock/kvg which contains a subdirectory "cmd" where there is read-write-test.go which reads and writes the repository to check the formatting is OK.

I just tried it out, and it's fantastic! The --fix option, in particular, seems really great. I'll have to use it the next time I contribute. Thanks for your advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants