Moon #355
Merged
Moon #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automatically changes a number of cases where the bottom part of an 青 element was written using an 円 kanji but marked as 月 in the group with a subgroup of 円 to using a single group with 月 as the original value and 円 as the element value, without a subgroup. None of these groups was a radical or otherwise seemed to require special treatment.
Where the left stroke was labelled ㇑/㇒, it's been relabelled as ㇑, CJK Stroke S. This label seems to have been intended to indicate that the stroke was vertical but could be bent in some cases, but its used was inconsistent, so I decided to remove it. Where the left stroke was labelled ㇒, two actions were taken depending on the properties of the stroke. Where the stroke appeared to bend left at the bottom, the stroke was relabelled ㇓, CJK Stroke SP, which is the correct stroke type for this according to the documentation available. Where the stroke appeared to be straight at the bottom and vertical, the stroke was relabelled ㇑, CJK Stroke S. (Some of the strokes had a small kink at the top.) All of the files in the second case had "Kaisho" in the file name, except for one exception, 0745c-VtLst.svg.
This was
linked to
issues
Apr 29, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the left stroke of 月 more consistent.