Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join needlessly-separated groups #352

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Join needlessly-separated groups #352

merged 2 commits into from
Apr 26, 2022

Conversation

benkasminbullock
Copy link
Member

Some of the files had two groups with part=1 part=2 with the same
element next to each other. This removes all such groups, and also
renumbers the succeeding parts of the group where they exist

Some of the files had two groups with part=1 part=2 with the same
element next to each other. This removes all such groups, and also
renumbers the succeeding parts of the group where they exist
@benkasminbullock benkasminbullock linked an issue Apr 25, 2022 that may be closed by this pull request
This does some more cases where the file has two joined groups.

The script which does this work is not very sophisticated, so it was
necessary to run it twice for cases there were two instances of groups
which should be joined.

I also ran it a third time, but there were no cases of three sets of
groups like this.
Copy link
Member Author

@benkasminbullock benkasminbullock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the kvg:partial field ought also to be fixed, but that also seems to have been inconsistently applied to the files.

@benkasminbullock benkasminbullock merged commit fb5e3ae into master Apr 26, 2022
@benkasminbullock benkasminbullock deleted the contig branch April 27, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join contiguous groups which are parts
1 participant