Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usu #295

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Fix usu #295

merged 3 commits into from
Apr 13, 2022

Conversation

benkasminbullock
Copy link
Member

This pull request was submitted yesterday but got damaged by some kind of cross-fire from other changes. This fixes 臼 stroke order errors as described in issue 180 and the previous pull requests etc. This was done partly by hand-editing files to get them consistent, then by applying a script across all the files. It is possible that errors remain in some files, especially where they were swapped based on the name of the file (from HzFst to plain, from plain to HzLst). Git diff shows these changes as HzFst being changed to HzLst with slightly different contents, but in fact they are moves of files without editing the contents, hence the file contents were not actually checked at all.

I'm planning to merge this fairly rapidly unless anyone objects.

This gets a lot of files into better order by removing minor errors or
reclassifying wrong groups, so that the usu script can run cleanly.
This runs a script which moves files around and deletes old files, as
well as editing files where there is no HzFst version to move the
strokes around.
Some groups were added in a deleted commit so I'm adding them again
here.
@benkasminbullock benkasminbullock merged commit eea1f60 into master Apr 13, 2022
@benkasminbullock benkasminbullock deleted the fix-usu branch April 13, 2022 02:34
@benkasminbullock benkasminbullock mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant