Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The problem of issue 204 across all of KanjiVG #294

Merged
merged 1 commit into from
Apr 13, 2022
Merged

The problem of issue 204 across all of KanjiVG #294

merged 1 commit into from
Apr 13, 2022

Conversation

benkasminbullock
Copy link
Member

@benkasminbullock
Change bad path type in 𠕁 subelements
7df2677 
This change consists of searching for 𠕁 elements with IDS, then
searching the KanjiVG file for a group with element 冊, then looking
at this group's paths to see if they correspond to the type, and
swapping them around if so. The single-element groups on these paths
were in a mess already, so I have just removed them completely.

From the groupings, it seems as if this was done to add another stroke
order variant for this 冊 piece, but in fact all of the found elements
in KanjiVG had the same stroke order.
@benkasminbullock benkasminbullock merged commit 8562d7c into master Apr 13, 2022
@benkasminbullock benkasminbullock deleted the issue204 branch April 13, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benkasminbullock