Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced and missing stroke numbers #50

Closed
eichhirn opened this issue Jan 24, 2013 · 5 comments
Closed

Misplaced and missing stroke numbers #50

eichhirn opened this issue Jan 24, 2013 · 5 comments

Comments

@eichhirn
Copy link
Contributor

There are a number of files where the order of strokes and numbers does not match. In the majority of cases, it is the numbers that are placed incorrectly, although there might be a small number of cases where the actual stroke order is wrong.

In 274 files some or all of the stroke numbers are missing. This affects all kana and latin characters. A majority of them was probably lost in the conversion to the combined xml/svg format ("kanji" directory). They still exist in the old "SVG" directory:
https://github.com/KanjiVG/kanjivg/tree/5e8ff1bed36d8e11866f83b67f5f5b5e5af384e0

The topic of misplaced stroke numbers was discussed a while ago in
https://groups.google.com/forum/?fromgroups=#!topic/kanjivg/-0qmqfLj_aE
Repeating my last post there:

  1. My stroke number placement checker reports 1644 files as possibly buggy, among them
    Stroke swaps = 1503 Wrong stroke direction = 542 Missing numbers = 274
    The output of the Stroke number placement checker is here:
    https://gist.github.com/3132779
  2. Another program of mine that places stroke numbers automatically can be used to check the manual stroke numbers. The output is here:
    https://docs.google.com/open?id=0B-TA0GJ6dksVVnRiZExtTkdpSU0

This issue also covers #34, #30, #29, #28, #27, #19, #15, #14 (partial), #9, #8, #6, #2.

@eichhirn
Copy link
Contributor Author

Update:
Due to changes by ospalh and myself, the situation has improved a bit.
There are now 1157 possibly buggy files, among them
Stroke swaps = 1004 Wrong stroke direction = 244 Missing numbers = 0
I have updated the files with the error reports.
I have added a report for Jouyou items only. In this range there are only 59 files with problems left.

@ospalh
Copy link
Member

ospalh commented Jul 25, 2014

Could you perhaps run your scripts a third time?
I went through the collection and fixed quite a number of files, so my guess is that it has improved again.

@eichhirn
Copy link
Contributor Author

eichhirn commented Aug 4, 2014

Okay,
I updated this one: https://gist.github.com/3132779
Now the summary reads:
Files with possible errors = 729 Stroke swaps = 563 Stroke direction = 200 Missing numbers = 0 Duplicate numbers = 1

ospalh added a commit that referenced this issue Aug 16, 2014
Fix the real problems spotted by a script by @eichhirn. See #50
@ospalh
Copy link
Member

ospalh commented Aug 16, 2014

Done. 6d0d6d0
There are still some files where the script will complain,. For some the numbers could be moved in a bit, but i think they are acceptable. For some there is not really any better spot.

@ospalh ospalh closed this as completed Aug 16, 2014
@eichhirn
Copy link
Contributor Author

Great job. Another update: https://gist.github.com/3132779 results in:
Files with possible errors = 281 Stroke swaps = 241 Stroke direction = 51 Missing numbers = 0 Duplicate numbers = 0
All I checked manually were false positives.
A future change could use varying (smaller) font sizes where necessary. In my auto placement tool I now prefer putting the numbers on top of the strokes, not next to them. Updated output: https://docs.google.com/open?id=0B-TA0GJ6dksVVnRiZExtTkdpSU0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants