Iterate ParseIter during Bench #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11 did not iterate through the parsed characters, which produced inaccurate bench results. This PR:
criterionUpdated results compared to pre-#11 run from a different machine:
Winner: Attackgoat: Before=1.3us After=455nsVan Gogh my earlo...[~520 CHARS]: Before=35us After=16.7usThis is the perf graph for
Winner: Attackgoat; blue is this PR and red isd47fc1ewithf8918b7:I noticed this discrepancy when performance profiling some other code. This library is still fast but I was expecting more from the previous PR.