update some funcs and put (find_group new_line send_enter type_message) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leggewie
reviewed
Oct 4, 2023
| @@ -265,7 +268,7 @@ def search_chat_by_name(self, query: str): | |||
| search_box.send_keys(Keys.ARROW_DOWN) | |||
| chat = self.browser.switch_to.active_element | |||
|
|
|||
| # acceptable here as an exception! | |||
| # excepcitonally acceptable here! | |||
|
Please do NOT merge this. There are a bunch of unrelated changes, including regressions. It needs to be understood what the problem is with regards to Arabic and only then should a proper minimal fix be pushed. Maybe best to reject this changeset and open a bug ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you want to use this library with Arabic languge it give you mistakes especially with long messages,
thats whay I did this fast modifing and add some changes to suit Arabic.