up detekt to 1.19 and fix some warnings

build.gradle.kts

@@ -4,16 +4,16 @@ plugins {
 
 detekt {
     toolVersion = libs.versions.detekt.get()
-    input = files(subprojects.map {
+    source = files(subprojects.map {
         File(it.projectDir, "/src/main/kotlin")
     })
     buildUponDefaultConfig = true
     config = files("$projectDir/detekt-config.yml")
     baseline = file("$projectDir/detekt-baseline.xml")
 
     reports {
-        html.enabled = true
-        xml.enabled = true
+        html.required.set(true)
+        xml.required.set(true)
     }
 }
 

buildSrc/src/main/kotlin/convention.application.gradle.kts

@@ -8,7 +8,7 @@ plugins {
 }
 
 withVersionCatalog { libs ->
-    configure<AppExtension>() {
+    configure<AppExtension> {
         defaultConfig {
             targetSdk = libs.versions.targetSdk.get().toInt()
             testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"

buildSrc/src/main/kotlin/convention.publishing.gradle.kts

@@ -77,7 +77,7 @@ configure<PublishingExtension> {
 }
 
 plugins.withId("com.android.library") {
-    configure<LibraryExtension>() {
+    configure<LibraryExtension> {
         publishing {
             singleVariant("release") {
                 withJavadocJar()

gradle/libs.versions.toml

@@ -7,7 +7,7 @@ compileSdk = "34"
 minSdk = "14"
 
 agpVersion = "8.2.1"
-kotlinVersion = "1.9.21"
+kotlinVersion = "1.9.22"
 
 dokkaVersion = "1.9.10"
 appcompatVersion = "1.6.1"
@@ -25,7 +25,7 @@ junitExtVersion = "1.1.5"
 multidexVersion = "2.0.1"
 materialVersion = "1.11.0"
 
-detekt = "1.17.1"
+detekt = "1.19.0"
 
 githubApiVersion = "1.318"
 

kakao/src/main/kotlin/io/github/kakaocup/kakao/chipgroup/ChipGroupActions.kt

@@ -33,7 +33,6 @@ interface ChipGroupActions : BaseActions {
                     }
                 }
             }
-
         })
     }
 
@@ -54,14 +53,13 @@ interface ChipGroupActions : BaseActions {
                     chip.performClick()
                 }
             }
-
         })
     }
 
     /**
      *  Select a Chip in a ChipGroup at a particular index
      *
-     *  @param index ChipGroup Chip indes
+     *  @param index ChipGroup Chip index
      */
     fun selectChipAt(index: Int) {
         view.perform(object : ViewAction {
@@ -80,7 +78,6 @@ interface ChipGroupActions : BaseActions {
                     }
                 }
             }
-
         })
     }
 }

kakao/src/main/kotlin/io/github/kakaocup/kakao/common/actions/BaseActions.kt

@@ -3,7 +3,6 @@
 package io.github.kakaocup.kakao.common.actions
 
 import android.view.View
-import androidx.test.espresso.FailureHandler
 import androidx.test.espresso.ViewAction
 import androidx.test.espresso.action.CoordinatesProvider
 import androidx.test.espresso.action.GeneralLocation
@@ -82,7 +81,7 @@ interface BaseActions {
      * @param function Lambda that handles this view's errors
      */
     fun onFailure(function: (error: Throwable, matcher: Matcher<View>) -> Unit) {
-        view.withFailureHandler(FailureHandler { error, viewMatcher -> function(error, viewMatcher) })
+        view.withFailureHandler { error, viewMatcher -> function(error, viewMatcher) }
     }
 
     /**

kakao/src/main/kotlin/io/github/kakaocup/kakao/common/matchers/DrawableMatcher.kt

@@ -18,7 +18,6 @@ import io.github.kakaocup.kakao.common.utilities.getResourceDrawable
 import org.hamcrest.Description
 import org.hamcrest.TypeSafeMatcher
 
-
 /**
  * Matches given drawable with current one
  *

kakao/src/main/kotlin/io/github/kakaocup/kakao/common/matchers/SelectedChipMatcher.kt

@@ -10,7 +10,7 @@ import org.hamcrest.Description
  *
  * @see Chip
  */
-class SelectedChipMatcher() :
+class SelectedChipMatcher :
     BoundedMatcher<View, Chip>(Chip::class.java) {
     override fun describeTo(description: Description) {
         description.appendText("Chip is checked")

kakao/src/main/kotlin/io/github/kakaocup/kakao/common/views/KBaseView.kt

@@ -23,15 +23,15 @@ import org.hamcrest.Matchers
 /**
  * Base class for all Kakao views
  *
- * This base class allows create new custom view with ease. All you
+ * This base class allows to create new custom view with ease. All you
  * have to do is to extend this class, implement all necessarily additional
  * actions/assertions interfaces and override necessary constructors
  *
  * @param T Type of your custom view. Needs to be defined to enable invoke() and perform() for descendants
  */
 @KakaoDslMarker
 open class KBaseView<T> : KDSLView<T>, BaseActions, BaseAssertions, Interceptable<ViewInteraction, ViewAssertion, ViewAction> {
-    override val view: ViewInteractionDelegate
+    final override val view: ViewInteractionDelegate
     override var root: Matcher<Root> = RootMatchers.DEFAULT
 
     /**

kakao/src/main/kotlin/io/github/kakaocup/kakao/pager2/KViewPager2.kt

@@ -104,7 +104,7 @@ class KViewPager2 : ViewPager2Actions, ViewPager2AdapterAssertions, SwipeableAct
 
         try {
             scrollTo(position)
-        } catch (error: Throwable) {
+        } catch (_: Throwable) {
         }
 
         val vb = ViewBuilder().apply {

kakao/src/main/kotlin/io/github/kakaocup/kakao/progress/PreciseSwipe.kt

@@ -10,14 +10,15 @@ import androidx.test.espresso.action.Swiper
 import androidx.test.espresso.core.internal.deps.guava.base.Preconditions.checkElementIndex
 
 object PreciseSwipe : Swiper {
+
+    private const val EVENT_COUNT = 40
+    private const val DURATION_MS = 1000L
+    private const val TAG = "PreciseSwipe"
+
     override fun sendSwipe(
         uiController: UiController, startCoordinates: FloatArray,
         endCoordinates: FloatArray, precision: FloatArray
     ): Swiper.Status {
-        checkNotNull(uiController)
-        checkNotNull(startCoordinates)
-        checkNotNull(endCoordinates)
-        checkNotNull(precision)
 
         val steps = interpolate(startCoordinates, endCoordinates, EVENT_COUNT)
         val delayBetweenMovements = DURATION_MS / steps.size
@@ -65,9 +66,4 @@ object PreciseSwipe : Swiper {
 
         return res
     }
-
-    private const val EVENT_COUNT = 40
-    private const val DURATION_MS = 1000L
-    private const val TAG = "PreciseSwipe"
-
 }

kakao/src/main/kotlin/io/github/kakaocup/kakao/recycler/KRecyclerView.kt

@@ -110,7 +110,7 @@ class KRecyclerView : RecyclerActions, BaseAssertions, RecyclerAdapterAssertions
 
         try {
             scrollTo(position)
-        } catch (error: Throwable) {
+        } catch (_: Throwable) {
         }
 
         function((provideItem(PositionMatcher(matcher, position)) as T).also { inRoot { withMatcher([email protected]) } })
@@ -162,7 +162,7 @@ class KRecyclerView : RecyclerActions, BaseAssertions, RecyclerAdapterAssertions
 
         try {
             scrollTo(childMatcher)
-        } catch (error: Throwable) {
+        } catch (_: Throwable) {
         }
 
         return (provideItem(

kakao/src/main/kotlin/io/github/kakaocup/kakao/screen/Screen.kt

@@ -135,6 +135,10 @@ open class Screen<out T : Screen<T>> : ScreenActions {
     }
 
     companion object {
+        internal val viewInterceptors: Deque<Interceptor<ViewInteraction, ViewAssertion, ViewAction>> = LinkedList()
+        internal val dataInterceptors: Deque<Interceptor<DataInteraction, ViewAssertion, ViewAction>> = LinkedList()
+        internal val webInterceptors: Deque<Interceptor<Web.WebInteraction<*>, WebAssertion<*>, Atom<*>>> = LinkedList()
+
         /**
          * Idles for given amount of time
          *
@@ -167,9 +171,5 @@ open class Screen<out T : Screen<T>> : ScreenActions {
                 .newInstance()
                 .apply { this(function) }
         }
-
-        internal val viewInterceptors: Deque<Interceptor<ViewInteraction, ViewAssertion, ViewAction>> = LinkedList()
-        internal val dataInterceptors: Deque<Interceptor<DataInteraction, ViewAssertion, ViewAction>> = LinkedList()
-        internal val webInterceptors: Deque<Interceptor<Web.WebInteraction<*>, WebAssertion<*>, Atom<*>>> = LinkedList()
     }
 }