Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SeqLSTM #46

Merged
merged 1 commit into from
Sep 25, 2016
Merged

Use SeqLSTM #46

merged 1 commit into from
Sep 25, 2016

Conversation

JoostvDoorn
Copy link
Contributor

@JoostvDoorn JoostvDoorn commented Jun 25, 2016

I am rewriting some stuff to use SeqLSTM instead of FastLSTM with the recurrent option. This will make things faster, especially if people start using longer histories. Depends on torch/nn#861, and torch/nn#889.

@Kaixhin
Copy link
Owner

Kaixhin commented Jun 25, 2016

Looks great! And should make it easier if there are future improvements to LSTMs as they'll probably come from having a sequential unit. Given torch/nn#860, Bottle.lua can be removed from this PR?

@lake4790k
Copy link
Collaborator

In Model for async the net was built without a Sequencer before. Now Model builds SeqLSTM for async as well, so logic would change there. I'm not sure if will be correct, but it's fine for now, I'll have a look later anyway when extending recurrent mode to all async agents (only 1 step is considered currently).

Kaixhin added a commit that referenced this pull request Aug 6, 2016
@Kaixhin
Copy link
Owner

Kaixhin commented Aug 16, 2016

@JoostvDoorn are we ready to merge this now (pending resolving any conflicts)?

@JoostvDoorn
Copy link
Contributor Author

@Kaixhin I think so. I will clean this up, and prepare for merge.

@Kaixhin
Copy link
Owner

Kaixhin commented Sep 3, 2016

@JoostvDoorn Any updates?

@JoostvDoorn
Copy link
Contributor Author

Sorry for the delay. I cleaned up the code, will be running some tests to see if it still works.

@JoostvDoorn
Copy link
Contributor Author

The code as such will break async, it is probably fine if async uses FastLSTM and use SeqLSTM for recurrent. @Kaixhin what is your take on this?

@Kaixhin
Copy link
Owner

Kaixhin commented Sep 11, 2016

Seeing as recurrency was only supported for one-step async, I think it's fine to focus on the DQN for now. That said, eventually it would be good to get recurrent support for all async agents, even if they need different implementations.

@JoostvDoorn
Copy link
Contributor Author

It should now work for recurrent DQN, and should not break async. Sorry for taking such a long time, I am not working with this code at the moment.

@Kaixhin Kaixhin merged commit a271098 into Kaixhin:master Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants