Implement cache for downloaded models. #8
Conversation
|
It is failing b/c I am using the However, the I will find another way to set the environment variable cleanly in tests. |
Default cache directory is ~/.cache/kagglehub. Can be overriden globally by KAGGLEHUB_CACHE env variable. Can be overriden for a single call using the `cache_dir` parameter. Also include logic for parsing the model handle. Next: Implement downloading file on cache miss. http://b/305949898
|
|
||
| def _install_resolvers(): |
There was a problem hiding this comment.
moved this logic directly to __init__.py to avoid cyclical dependencies.
|
|
||
| DEFAULT_CACHE_FOLDER = os.path.join(Path.home(), ".cache", "kagglehub") |
There was a problem hiding this comment.
Could it be possible that this .cache directory doesn't exist? Should we check and create it otherwise?
There was a problem hiding this comment.
Yes, it will likely not exist. My thinking was that the caller (here, the HttpResolver) would call "os.makedirs()" with the path to the model before copying the file which will create all intermediaries folder.
Default cache directory is ~/.cache/kagglehub.
Can be overriden globally by KAGGLEHUB_CACHE env variable. Can be overriden for a single call using the
cache_dirparameter.Also include logic for parsing the model handle.
Next: Implement downloading file on cache miss.
http://b/305947384