Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model upload #43

Merged
merged 79 commits into from
Dec 19, 2023
Merged

Model upload #43

merged 79 commits into from
Dec 19, 2023

Conversation

mohami2000
Copy link
Contributor

Implements functionality for kagglehub users to be able to upload models:
https://buganizer.corp.google.com/issues/312511716

@mohami2000 mohami2000 requested a review from rosbo December 19, 2023 14:14
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to upload a few model instances successfully :)

I added a few small comments.

Congrats on your first significant PR :)

Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, creating a new model instance works.

However, creating a new model instance version fails:

I added a print statement to debug and it returns a 500:

hatch run python -c "import kagglehub; kagglehub.model_upload('rosebv/test-kagglehub/pyTorch/dot', '/usr/local/google/home/rosbo/Documents/test-model', 'Apache 2.0')"
Starting upload for file dot.png
Upload successful: dot.png (150B)
ROSBO: {'code': 500, 'message': 'InternalServerError'}
Model Instance Version for 'rosebv/test-kagglehub/pyTorch/dot' Created.

@mohami2000
Copy link
Contributor Author

Actually, creating a new model instance works.

However, creating a new model instance version fails:

I added a print statement to debug and it returns a 500:

hatch run python -c "import kagglehub; kagglehub.model_upload('rosebv/test-kagglehub/pyTorch/dot', '/usr/local/google/home/rosbo/Documents/test-model', 'Apache 2.0')"
Starting upload for file dot.png
Upload successful: dot.png (150B)
ROSBO: {'code': 500, 'message': 'InternalServerError'}
Model Instance Version for 'rosebv/test-kagglehub/pyTorch/dot' Created.

should be fixed now :)

Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading a new version is working now :)

@mohami2000 mohami2000 merged commit f740040 into main Dec 19, 2023
6 checks passed
@mohami2000 mohami2000 deleted the model_upload branch December 19, 2023 21:20
mohami2000 added a commit that referenced this pull request Dec 21, 2023
Implements functionality for kagglehub users to be able to upload
models:
https://buganizer.corp.google.com/issues/312511716
mohami2000 added a commit that referenced this pull request Dec 21, 2023
Implements functionality for kagglehub users to be able to upload
models:
https://buganizer.corp.google.com/issues/312511716
mohami2000 added a commit that referenced this pull request Dec 21, 2023
Implements functionality for kagglehub users to be able to upload
models:
https://buganizer.corp.google.com/issues/312511716
@rosbo rosbo mentioned this pull request Dec 21, 2023
@Kaggle Kaggle deleted a comment from rosbo Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants