Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log for Kaggle Cache Resolver. #40

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Dec 7, 2023

  • Clarifiy whether the user is accessing a single file or the full model.
  • Do not print "Mounting files ..." if the model is already mounted.
  • Remove the "Model X is attached" at the end. The method returning the path is already enough. This is spammy.

The goal is to reduce the spammy log since Keras will be attaching several files.

- Clarifiy whether the user is accessing a single file or the full
  model.
- Do not print "Mounting files ..." if the model is already mounted.
- Remove the "Model X is attached" at the end. The method returning the
  path is already enough. This is spammy.

The goal is to reduce the spammy log since Keras will be attaching
several files.

Before: https://screenshot.googleplex.com/4KvivYGDqVxCngc
After: https://screenshot.googleplex.com/9YPyQG5oW5B87iS
@rosbo rosbo requested review from Philmod and mohami2000 and removed request for Philmod December 7, 2023 19:48
@rosbo rosbo force-pushed the improve-kaggle-resolver-logging branch from 6a7ca77 to d06963b Compare December 7, 2023 19:50
@rosbo rosbo requested a review from Philmod December 11, 2023 19:29
@rosbo rosbo merged commit 85dbc29 into main Dec 11, 2023
@rosbo rosbo deleted the improve-kaggle-resolver-logging branch December 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants