Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login widget #28

Merged
merged 37 commits into from
Nov 22, 2023
Merged

Login widget #28

merged 37 commits into from
Nov 22, 2023

Conversation

mohami2000
Copy link
Contributor

@mohami2000 mohami2000 requested a review from rosbo November 22, 2023 19:28
except Exception as error:
message = str(error)
# Print result (success message or error)
login_token_widget.children = [widgets.Label(line) for line in message.split("\n") if line.strip()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those this allow you to try again with a new set of credentials?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, you would have to run kagglehub.login() again in your notebook. if we make it automatically allow the user to login again, we would need to put a maximum number of retries i think? because else, if our server is down or the user forgot his credentials, it will keep popping up

@mohami2000 mohami2000 requested a review from rosbo November 22, 2023 22:19
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job adding this widget :)

@mohami2000 mohami2000 merged commit d1945c1 into main Nov 22, 2023
@mohami2000 mohami2000 deleted the login_widget branch November 22, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants