Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement login() in kagglehub #23

Merged
merged 31 commits into from
Nov 15, 2023
Merged

Implement login() in kagglehub #23

merged 31 commits into from
Nov 15, 2023

Conversation

mohami2000
Copy link
Contributor

added login() function, tests, and associated changes in config.py
https://screenshot.googleplex.com/66ZZ3UcBkVUdGCu.png

rosbo and others added 10 commits November 13, 2023 17:50
@rosbo @mohami2000
Remove extra slash in /kaggle/input path. (#21)
462b5d3 
https://screenshot.googleplex.com/7mQMShJYGZPqk8d
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
7e70c6a 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
9fbf00f 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
28bf1be 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
bc11ef4 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
dfa5dc3 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
796a732 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
21031a3 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
01b5dde 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
2645c0a 
…gin_3
rosbo
rosbo requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR!

mohami2000 and others added 11 commits November 14, 2023 00:20
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
457241c 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
feb5a50 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
a35574b 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
fe201a6 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
0c885df 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
f647565 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
845d222 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
72e42d7 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
8d681d6 
…gin_3
@mohami2000
Merge branch 'login_3' of https://github.com/Kaggle/kagglehub into lo…
d118dec 
…gin_3
@mohami2000
Delete Untitled.ipynb
c9fac9f
rosbo
rosbo reviewed Nov 14, 2023
View reviewed changes
rosbo
rosbo reviewed Nov 14, 2023
View reviewed changes
rosbo
rosbo reviewed Nov 14, 2023
View reviewed changes
@mohami2000 mohami2000 requested a review from rosbo November 15, 2023 20:40
rosbo
rosbo approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small nit, otherwise LGTM.

@mohami2000 mohami2000 merged commit 95612cb into main Nov 15, 2023
@mohami2000 mohami2000 deleted the login_3 branch November 15, 2023 21:05
mohami2000 added a commit that referenced this pull request Nov 16, 2023
@mohami2000 @rosbo
Implement login() in kagglehub (#23)
03b4b7b 
added login() function, tests, and associated changes in config.py
https://screenshot.googleplex.com/66ZZ3UcBkVUdGCu.png

---------

Co-authored-by: Vincent Roseberry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosbo rosbo rosbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohami2000 @rosbo