Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign model and publish to sigstore #211

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Sign model and publish to sigstore #211

merged 10 commits into from
Jan 23, 2025

Conversation

neshdev
Copy link
Member

@neshdev neshdev commented Jan 17, 2025 •
edited
Loading

  • Includes model_signing library
  • Integrated model signing identity jwt oidc token
  • Added sigstore variable to model_upload which is defaulted to false
  • Added unit tests to mock token logic
  • Signing file is generated as {model_dir}/.kaggle/signing.json
  • Minor change to pyproject.toml file to installer = "pip" as the default uv installer was unable to resolve the environment with all the dependencies.

By default, if sigstore signing fails, then signing is skipped altogether.

DEMO=https://screenshot.googleplex.com/6LCcDVb3haN3Uta

@neshdev neshdev changed the title Neshdev sign1 Sign model and publish to sigstore Jan 17, 2025
@neshdev neshdev marked this pull request as ready for review January 17, 2025 20:31
@neshdev neshdev requested review from a team, thkim1011 and dolaameng January 17, 2025 20:56
thkim1011
thkim1011 approved these changes Jan 17, 2025
View reviewed changes
Copy link

@thkim1011 thkim1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Also should someone from ML workflow review as well since they own kagglehub now?

@neshdev neshdev requested a review from jplotts January 21, 2025 15:58
@neshdev neshdev merged commit 0c9f1a8 into main Jan 23, 2025
6 checks passed
@neshdev neshdev deleted the neshdev-sign1 branch January 23, 2025 13:44
dster2 added a commit that referenced this pull request Feb 3, 2025
@dster2
Revert "Sign model and publish to sigstore (#211)"
b70fa39 
This reverts commit 0c9f1a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thkim1011 thkim1011 thkim1011 approved these changes

@jplotts jplotts jplotts approved these changes

@dolaameng dolaameng Awaiting requested review from dolaameng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neshdev @thkim1011 @jplotts