Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load_dataset to kagglehub module #197

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add load_dataset to kagglehub module #197

merged 2 commits into from
Dec 18, 2024

Conversation

goeffthomas
Copy link
Contributor

Notes:

  • The implementaiton didn't change at all--this just officially exposes the method via kagglehub.load_dataset
  • Updated saved scripts to reference the new location
  • Added many file test files with simliar content to add a better suite of unit tests
  • Added documentation for how to use load_dataset

http://b/379756505

@goeffthomas
Add load_dataset to kagglehub module
9cce13b 
Notes:
- The implementaiton didn't change at all--this just officially exposes the method via `kagglehub.load_dataset`
- Updated saved scripts to reference the new location
- Added many file test files with simliar content to add a better suite of unit tests
- Added documentation for how to use `load_dataset`

http://b/379756505
jplotts
jplotts approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jplotts jplotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, and thanks for the test improvements!

@goeffthomas goeffthomas merged commit e33023f into main Dec 18, 2024
6 checks passed
@goeffthomas goeffthomas deleted the finish-load-dataset branch December 18, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplotts jplotts jplotts approved these changes

@neshdev neshdev Awaiting requested review from neshdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goeffthomas @jplotts