Add tests for auto-(de)compression #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: - This is follow on work from #194 - Also added some integration tests - Note that not all stubs have been moved to this redirect path. Only the paths that could have compressed URLs in prod have been affected (Comps and Datasets). We can move all download paths to use this if we'd like. http://b/379756505
rosbo
approved these changes
Dec 16, 2024
| def test_auto_decompress_file(self) -> None: | ||
| with create_test_cache(): | ||
| # sample_submission.csv is an auto-compressed CSV with the following columns | ||
| expected_columns = ["TransactionId", "isFraud"] |
There was a problem hiding this comment.
Thanks for adding integration tests with deeper assertion to ensure we don't regress on this!
| def assert_files(test_case: unittest.TestCase, path: str, expected_files: list[str]) -> bool: | ||
| def list_columns(path: str) -> list[str]: | ||
| """Assuming the path is a CSV, list all columns sorted lexicographically""" | ||
| with open(path) as file: |
There was a problem hiding this comment.
Alternatively, you can use csv.reader from the Python standard library.
https://docs.python.org/3/library/csv.html#csv.reader
But given this is really simple, I will leave it up to you.
There was a problem hiding this comment.
Yeah, I think given the simplicity, I'll leave it for now. If we want more robust features later or run into issues that the library better handles, I'd be happy to switch it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
http://b/379756505