Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-hatch and documentation #193

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

goeffthomas
Copy link
Contributor

Notes:

  • Add a marker flag (with documentation) to indicate when the remaining args should pass through to hatch
  • Fixed a bug where usage would start a python shell
  • Other changes just help document some slightly easier ways to run python commands when using hatch instead of having to force everything into a long, inconvenient one-liner

http://b/379756505

Notes:
- Add a marker flag (with documentation) to indicate when the remaining args should pass through to hatch
- Fixed a bug where `usage` would start a `python` shell
- Other changes just help document some slightly easier ways to run python commands when using hatch instead of having to force everything into a long, inconvenient one-liner

http://b/379756505
@goeffthomas goeffthomas requested review from rosbo and neshdev December 12, 2024 22:18
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving hatch and ./docker-hatch support!

#!/usr/bin/env python
import kagglehub

print("path: ", kagglehub.model_download("google/bert/tensorFlow2/answer-equivalence-bem")) # noqa: T201
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably update this config to exclude all Python files under tools/scripts/ from the linter as opposed to adding noqa and things like that.

@goeffthomas goeffthomas merged commit 315701c into main Dec 12, 2024
6 checks passed
@goeffthomas goeffthomas deleted the update-docker-hatch-and-docs branch December 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants