Implement Kaggle Cache Resolver #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we detect we are inside a Kaggle notebook (via the `KAGGLE_KERNEL_RUN_TYPE` env variable), then we call the `AttachDatasourceUsingJwtHandler`. http://b/305947763
rosbo
commented
Nov 1, 2023
|
|
||
| logger.info(f"Mounting files to {cached_path}...") | ||
| while not os.path.exists(cached_path): | ||
| time.sleep(5) |
There was a problem hiding this comment.
Note: This waits until the file is ready. We can add later a separate endpoint to poll for progress. Given that we already show progress in the editor UI, probably not high priority.
A user can always send an interrupt (e.g. ctrl + c or click "stop cell" button in a notebook) if they want to stop the waiting.
Philmod
approved these changes
Nov 2, 2023
| @@ -28,6 +34,7 @@ | |||
| "error": logging.ERROR, | |||
| "critical": logging.CRITICAL, | |||
| } | |||
| TRUTHY_VALUES = ["true", "1", "t"] | |||
There was a problem hiding this comment.
I have seen this for a few env vars in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we detect we are inside a Kaggle notebook (via the
KAGGLE_KERNEL_RUN_TYPEenv variable), then we call theAttachDatasourceUsingJwtHandler.Also, I added a
DISABLE_KAGGLE_CACHEenvironment variable. If set to a truthy value, the KaggleCacheResolver will be skipped.Next: Call
AttachDatasourceUsingJwtHandlerthrough the Data Proxy inside internet disabled sessions.http://b/305947763