-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(code): add function to download notebook outputs #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bf8815
to
3c297d6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
rosbo
reviewed
Nov 22, 2024
calderjo
reviewed
Nov 22, 2024
rosbo
reviewed
Nov 22, 2024
calderjo
reviewed
Nov 22, 2024
7b53aa3
to
0cd1661
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6f10385
to
d0e5114
Compare
This comment was marked as resolved.
This comment was marked as resolved.
f9a66b0
to
6eb6af7
Compare
28ea68f
to
43197c4
Compare
KeijiBranshi
commented
Nov 27, 2024
@@ -10,7 +10,7 @@ | |||
from typing import Optional, Union | |||
|
|||
import requests | |||
from requests.exceptions import ConnectionError, Timeout | |||
from requests.exceptions import Timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: these are miscellaneous drive-by changes as per #issuecomment-2494710160
rosbo
approved these changes
Nov 27, 2024
fyi @calderjo going to merge now to unblock. lmk if you have any comments though and I can address in a follow up iteration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=b/371574828
CHILD=#185
BLOCKED_BY=go/kaggle-pr/32581,go/kaggle-pr/32632
CC=@rosbo,@dster2,@jplotts
Extends the same functionality from
models.py
,datasets.py
andcompetition.py
to the notebooks at https://kaggle.com/code.Changes
handle.py
*Handle
data typeCode
to align with the route on the main site https://kaggle.com/codecache.py
CodeHandle
model
,dataset
, andcompetition
paths.http_resolver.py
NotebookOutputHttpResolver
KaggleApiV1Client
+ the new cache location mentioned aboveregistry.py + __init__.py
NotebookOutputHttpResolver
so that it can be called bykagglehub.notebook_output_download
incode.py
code.py
code.py
to align with our navigation paths at https://kaggle.com (similar tomodels
,datasets
, andcompetitions
). Open to changing if needed.notebook_output_download
to be more specific about what's being downoadedtest_notebook_output_download.py
kagglehub.notebook_output_download
functiongcs_upload.py