Updated error message to include server side errors if present. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolaameng
reviewed
Nov 15, 2024
src/kagglehub/exceptions.py
Outdated
| @@ -58,6 +58,9 @@ def kaggle_api_raise_for_status(response: requests.Response, resource_handle: Op | |||
| response.raise_for_status() | |||
| except requests.HTTPError as e: | |||
| message = str(e) | |||
| server_error_message = response.json().get("message", "") | |||
There was a problem hiding this comment.
I guess some response are not json format so it fails some integration tests?
rosbo
requested changes
Dec 4, 2024
src/kagglehub/exceptions.py
Outdated
| if server_error_message: | ||
| server_error_message = f"The server reported the following issues: {server_error_message}\n" | ||
| server_error_message = "" | ||
| if response.headers.get("Content-Type") == "application/json": |
There was a problem hiding this comment.
Should probably do a case insensitive check.
add a try/except block to catch the requests.exception.JSONDecodeError: https://requests.readthedocs.io/en/latest/user/quickstart/#json-response-content
This way, if the mime type is application/json but the response is invalid, we won't break here.
There was a problem hiding this comment.
Skipping the header check all together and just using a try/catch instead.
rosbo
approved these changes
Dec 6, 2024
mohami2000
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message to include server side error messages if present in payload.
BUG=b/375194356