Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Colab credentials to get_kaggle_credentials. #165

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Oct 9, 2024

This ensures kagglehub.whoami() returns the proper value.

Before:
BXwpPiA9ji38oMD

After:
7AErWSvipSVWx2m

Next: Fix whoami() for inside a Kaggle notebook.

http://b/372503113

This ensures `kagglehub.whoami()` returns the proper value.

Before: https://screenshot.googleplex.com/BXwpPiA9ji38oMD
After:

Next: Fix `whoami()` for inside a Kaggle notebook.

http://b/372503113
@rosbo rosbo requested review from dolaameng and jeward414 October 9, 2024 20:54
Copy link
Contributor

@dolaameng dolaameng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better! Thank you!

@rosbo rosbo merged commit eded66f into main Oct 11, 2024
6 checks passed
@rosbo rosbo deleted the fix-whoami-colab branch October 11, 2024 12:43
rosbo added a commit that referenced this pull request Oct 11, 2024
Similar to #165 (handling for Colab secrets) but this is for handling
the default auth in Kaggle notebook.

Before, `whoami` would return unauthenticated when using default auth in
Kaggle notebook:

![8MDxdhZc6YDfTJA](https://github.com/user-attachments/assets/fa09a46b-e6b0-4566-b476-1ac518b439c2)


After, `whoami` returns the current username: 

![8MRE8FFqpmCLSnL](https://github.com/user-attachments/assets/578be681-8edd-4857-bba6-5e24286642f2)


http://b/372524708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants