Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add keras to user agent #152

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

dolaameng
Copy link
Contributor

@dolaameng dolaameng commented Aug 16, 2024

Enable tracking of keras model upload via kagglehub api. This is the change for kagglehub part. PR for midtier change is http://go/kaggle-pr/30947

Discussion: MM

FIX=b/343245882
Tested

@dolaameng dolaameng requested review from rosbo and a team August 19, 2024 17:03
@dolaameng dolaameng marked this pull request as ready for review August 19, 2024 17:03
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Just a few minor suggestions.

@dolaameng dolaameng merged commit c0de979 into main Aug 19, 2024
7 checks passed
@dolaameng dolaameng deleted the limagoog/feat/add_keras_model_referrer branch August 19, 2024 18:11
@neshdev
Copy link
Member

neshdev commented Aug 19, 2024

Please also add the PR to the bug after its complete. Adding testing evidence and replication steps to the bug is also good practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants