Integrate Token Auth in Notebooks #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
approved these changes
Jul 8, 2024
| @@ -171,9 +174,11 @@ def download_file(self, path: str, out_file: str, resource_handle: Optional[Reso | |||
| _CHECKSUM_MISMATCH_MSG_TEMPLATE.format(expected_md5_hash, actual_md5_hash) | |||
| ) | |||
|
|
|||
| def _get_http_basic_auth(self) -> Optional[HTTPBasicAuth]: | |||
| def _get_auth(self) -> Optional[requests.auth.AuthBase]: | |||
There was a problem hiding this comment.
I like to refactor to rely on AuthBase and have KaggleTokenAuth extend it. Very clean 👏
|
Did you also test it e2e in a Kaggle notebook? You can run the following in a cell (you probably already know, but sharing just in case): |
Yes. I did e2e testing here. Added my notes here: It worked as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token Auth will implicitly grant permissions to kaggle resources (models and datasets)