Reduce logging for Keras #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5415f3b.
rosbo
approved these changes
May 23, 2024
|
@neshdev Can you do the same for the kagglehub/src/kagglehub/kaggle_cache_resolver.py Lines 42 to 44 in c2593ce |
neshdev
commented
May 23, 2024
| @@ -39,9 +40,11 @@ def __call__(self, h: ModelHandle, path: Optional[str] = None, *, force_download | |||
| logger.warning("Ignoring invalid input: force_download flag cannot be used in a Kaggle notebook") | |||
|
|
|||
| if path: | |||
| logger.info(f"Attaching '{path}' from model '{h}' to your Kaggle notebook...") | |||
| logger.info( | |||
| f"Attaching '{path}' from model '{h}' to your Kaggle notebook...", extra={**EXTRA_CONSOLE_BLOCK} | |||
There was a problem hiding this comment.
@rosbo - Should I block it from showing up in the console, or do you want me to move it down after making the call. If its the latter, I think I would need to keep track of the state.
There was a problem hiding this comment.
I think it is useful to show in the console if the file is not mounted:
if os.path.exists(cached_path) : // already mounted, print to log file only
else: // not yet mounted, print to console too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://b.corp.google.com/issues/338419689