-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download model files in parallel when < X files #122
Conversation
@jeward414 I will add tests on Monday but here is what we did together. I also added the parallel download part. |
Note: integration test is failing until https://github.com/Kaggle/kaggleazure/pull/29608 is merged (@stevemessick is working on the backend fix). I will wait for the change to be deployed before merging this PR. |
fe1c465
to
695b4c1
Compare
WIP: Missing test and some refactor to make the code more reasable http://b/341160276
5b84f34
to
f91ae77
Compare
I found why the integration tests were failing on CI but not when running locally. There is a @stevemessick Are you planning to turn the feature flag to |
@rosbo That FF was supposed to have been 100% but the update didn't stick. I just verified it is now 100%. The FF will be removed by https://github.com/Kaggle/kaggleazure/pull/29772. |
I re-ran the failing check, and it is passing now. |
Thank you @stevemessick 👏 |
We started using the `ListModelInstanceVersionFiles` in #122 (not yet released but merged). However, I noticed this doesn't work for unauthenticated users. I added an integration test to ensure we don't regress on this once the backend is fixed. http://b/341160276
Blocked by: https://github.com/Kaggle/kaggleazure/pull/29608 (@stevemessick is working on the backend fix)
http://b/341160276