Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove zipping #105

Merged
merged 39 commits into from
Apr 26, 2024
Merged

remove zipping #105

merged 39 commits into from
Apr 26, 2024

Conversation

mohami2000
Copy link
Contributor

@mohami2000 mohami2000 commented Apr 22, 2024 •
edited by rosbo
Loading

This pr removes zipping before upload and instead passes the structure of a directory to the API directory

Fixes #103

rosbo
rosbo requested changes Apr 24, 2024
View reviewed changes
@mohami2000 mohami2000 requested a review from rosbo April 24, 2024 19:17
rosbo
rosbo reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to resolve the conflicts first and then re-request a review from me. Thanks

@mohami2000
Copy link
Contributor Author

Make sure to resolve the conflicts first and then re-request a review from me. Thanks

I think you are looking at a different pr?

@mohami2000 mohami2000 marked this pull request as ready for review April 24, 2024 21:15
@mohami2000 mohami2000 requested a review from rosbo April 24, 2024 21:16
rosbo
rosbo requested changes Apr 25, 2024
View reviewed changes
@mohami2000 mohami2000 requested a review from rosbo April 25, 2024 19:24
@mohami2000 mohami2000 requested a review from rosbo April 25, 2024 20:13
@mohami2000 mohami2000 requested a review from rosbo April 25, 2024 20:21
@mohami2000 mohami2000 requested a review from rosbo April 25, 2024 20:52
rosbo
rosbo approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the linter issue is fixed:

src/kagglehub/models_helpers.py:45:40: Q000 [*] Single quotes found but double quotes preferred

@mohami2000 mohami2000 merged commit 2bbfd39 into main Apr 26, 2024
7 checks passed
@mohami2000 mohami2000 deleted the remove_zipping branch April 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosbo rosbo rosbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload for private model yields "No instances available"
2 participants
@mohami2000 @rosbo