Add basic functions for determining step timing in replays #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-dmello
approved these changes
Nov 4, 2025
develra
reviewed
Nov 4, 2025
web/core/src/transformers.ts
Outdated
| return getPokerStepLabel(gameStep as RepeatedPokerStep); | ||
| default: | ||
| return ''; | ||
| return ""; |
There was a problem hiding this comment.
nbd but I think our prettier configs are fighting - can you make sure yours is using the .prettierrc in the root of this repo?
There was a problem hiding this comment.
@develra oh you're so right, I bet vscode made some decisions about which config to use and didn't tell me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just merge this now to mess with it further or hold off until we finish refactoring game steps- I know all the same information will be there though.