Update Kagglehub mock and unpin keras-nlp #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djherbis
approved these changes
May 28, 2024
rosbo
requested changes
May 28, 2024
rosbo
approved these changes
May 28, 2024
tests/utils/kagglehub.py
Outdated
| f"and copy it to `./docker-python/tests/data/kagglehub/models/{model_handle}/{path}`\n" | ||
| )) | ||
| self.send_error(404, "Internet is disabled in our tests " | ||
| "kagglehub uses a fake API server " |
There was a problem hiding this comment.
I think because you don't have \n. The output will be "kagglehub uses a fake API server Use kagglehub.model [...]`.
Let's either add a . after "fake API server".
rosbo
added a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrongly pinned keras-nlp, let's unpinned it. update mock to support optional files.
https://b.corp.google.com/issues/341982731