Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing io import in log.py #1326

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add missing io import in log.py #1326

merged 1 commit into from
Nov 27, 2023

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Nov 23, 2023

Fixes #1324.

We setup a custom logger for Kaggle kernels.

Some of this logic could be simplified now that we are using Python 3.8+. I filed b/312963888 for this.

b/312961350

Fixes #1324.

We setup a custom logger for Kaggle kernels.

Some of this logic could be simplified now that we are using Python 3.8+. I filed b/312963888 for this.

b/312961350
@@ -1,3 +1,4 @@
import io
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call io.StringIO at line 42:

sio = io.StringIO()

This is causing this error: #1324

@rosbo rosbo requested a review from djherbis November 23, 2023 21:30
@rosbo rosbo merged commit ba38086 into main Nov 27, 2023
4 checks passed
@rosbo rosbo deleted the add-missing-import-log branch November 27, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: name 'io' is not defined
2 participants