Fix broken docker build #1291
Merged
Fix broken docker build #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion. The base docker image contains two cuda installations which is causing errors for `cupy` package.
`cudf/api/types.py` has nominal impact to other packages.
pipe-ing to the file was causing an empty file.
Use pip installation.
rosbo
reviewed
Aug 21, 2023
| "${JAXVER}" && \ | ||
| "${JAXVER}" | ||
|
|
||
| RUN apt-get install -y default-jre |
There was a problem hiding this comment.
We call /tmp/clean-layer.sh to ensure the apt-cache is cleared at the end of the docker layer, otherwise, this makes this docker image layer larger and increase the total image size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added several fixes to resolve the issue
cupyas the first install so that thecudapath is resolved correctlycudf