Skip to content

Tenant git test fixes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KacieKK merged 2 commits into from
Apr 14, 2021
Merged

Tenant git test fixes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6cfa0b
test fixes
solankisamir Apr 13, 2021
1f7202a
domain ownership identifier test
solankisamir Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...osoft.Azure.Management.ApiManagement/tests/ManagementApiTests/AuthorizationServerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace ApiManagement.Tests.ManagementApiTests
public class AuthorizationServerTests : TestBase
{
[Fact]
[Trait("owner", "vifedo")]
[Trait("owner", "sasolank")]
public async Task CreateListUpdateDelete()
{
Environment.SetEnvironmentVariable("AZURE_TEST_MODE", "Playback");
Expand Down Expand Up @@ -94,8 +94,8 @@ public async Task CreateListUpdateDelete()
Assert.Equal(authorizationServerContract.ClientId, getResponse.Body.ClientId);
Assert.Equal(authorizationServerContract.ClientRegistrationEndpoint, getResponse.Body.ClientRegistrationEndpoint);
Assert.Null(getResponse.Body.ClientSecret);
Assert.Equal(authorizationServerContract.ResourceOwnerPassword, getResponse.Body.ResourceOwnerPassword);
Assert.Equal(authorizationServerContract.ResourceOwnerUsername, getResponse.Body.ResourceOwnerUsername);
Assert.Null(getResponse.Body.ResourceOwnerPassword);
Assert.Null(getResponse.Body.ResourceOwnerUsername);
Assert.Equal(authorizationServerContract.GrantTypes.Count, getResponse.Body.GrantTypes.Count);
Assert.True(getResponse.Body.GrantTypes.All(gt => authorizationServerContract.GrantTypes.Contains(gt)));
Assert.Equal(authorizationServerContract.AuthorizationMethods.Count, getResponse.Body.AuthorizationMethods.Count);
Expand All @@ -111,6 +111,8 @@ public async Task CreateListUpdateDelete()
testBase.serviceName,
authsid);
Assert.Equal(authorizationServerContract.ClientSecret, secretsResponse.ClientSecret);
Assert.Equal(authorizationServerContract.ResourceOwnerUsername, secretsResponse.ResourceOwnerUsername);
Assert.Equal(authorizationServerContract.ResourceOwnerPassword, secretsResponse.ResourceOwnerPassword);

// list again
listResponse = testBase.client.AuthorizationServer.ListByService(
Expand Down Expand Up @@ -154,8 +156,8 @@ public async Task CreateListUpdateDelete()
Assert.Equal(authorizationServerContract.ClientId, getResponse.Body.ClientId);
Assert.Equal(authorizationServerContract.ClientRegistrationEndpoint, getResponse.Body.ClientRegistrationEndpoint);
Assert.Null(getResponse.Body.ClientSecret);
Assert.Equal(authorizationServerContract.ResourceOwnerPassword, getResponse.Body.ResourceOwnerPassword);
Assert.Equal(authorizationServerContract.ResourceOwnerUsername, getResponse.Body.ResourceOwnerUsername);
Assert.Null(getResponse.Body.ResourceOwnerPassword);
Assert.Null(getResponse.Body.ResourceOwnerUsername);
Assert.Equal(updateParameters.GrantTypes.Count, getResponse.Body.GrantTypes.Count);
Assert.True(getResponse.Body.GrantTypes.All(gt => updateParameters.GrantTypes.Contains(gt)));
Assert.Equal(authorizationServerContract.AuthorizationMethods.Count, getResponse.Body.AuthorizationMethods.Count);
Expand Down
6 changes: 3 additions & 3 deletions ...Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/TenantAccessGitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace ApiManagement.Tests.ManagementApiTests
public class TenantAccessGitTests : TestBase
{
[Fact]
[Trait("owner", "vifedo")]
[Trait("owner", "sasolank")]
public async Task GetUpdateKeys()
{
Environment.SetEnvironmentVariable("AZURE_TEST_MODE", "Playback");
Expand Down Expand Up @@ -52,7 +52,7 @@ public async Task GetUpdateKeys()
testBase.client.TenantAccessGit.RegeneratePrimaryKey(
testBase.rgName,
testBase.serviceName,
"gitAccess");
"access");

var secretsResponse2 = await testBase.client.TenantAccess.ListSecretsAsync(
testBase.rgName,
Expand All @@ -66,7 +66,7 @@ public async Task GetUpdateKeys()
testBase.client.TenantAccessGit.RegenerateSecondaryKey(
testBase.rgName,
testBase.serviceName,
"gitAccess");
"access");

var getSecretsHttpResponse = await testBase.client.TenantAccess.ListSecretsWithHttpMessagesAsync(
testBase.rgName,
Expand Down
3 changes: 3 additions & 0 deletions ....Azure.Management.ApiManagement/tests/ResourceProviderTests/CreateMultiHostNameService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ public void CreateMultiHostNameService()
{
var testBase = new ApiManagementTestBase(context);

var domainOwnershipIdentifierResult = testBase.client.ApiManagementService.GetDomainOwnershipIdentifier();
Assert.NotNull(domainOwnershipIdentifierResult);

testBase.serviceProperties.Sku.Name = SkuType.Premium;
var hostnameConfig1 = new HostnameConfiguration()
{
Expand Down
Loading