Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HUD text display taking over other plugins' display #444

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

zer0k-z
Copy link
Contributor

@zer0k-z zer0k-z commented Jan 11, 2023

Related to #419, but does not really fix it because MHUD is still at fault.

The reuse logic with 6 channels is fine, and is not why the HUD text was unable to be displayed.
The cause is the client's internal message buffer which is 16 slots long and shared between 6 channels at once. The message in the buffer will only clear once the hold time is over. So a plugin sending one HUD message lasting for 0.5 seconds will immediately fill the buffer (that's 64 messages, which is way past 16), leaving no place for other plugins.

The reason joining team or sending round_start event temporarily fixes the issue is because they trigger the message buffer wipe, but they come with other unwanted side effects.

Reference

@zer0k-z
Copy link
Contributor Author

zer0k-z commented Jan 13, 2023

This should also fix speed text anti aliasing being broken.

@zealain zealain merged commit 592b2f5 into KZGlobalTeam:dev Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants