kvmi: increase the message size #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to read a whole page with KVMI_READ_PHYSICAL. Signed-off-by: Adalbert Lazăr <[email protected]>
|
@adlazar could you explain this modification, because it's not obvious to me why we are introducing a magic number |
|
For convenience, we've tried to keep the message limit small and page size multiple (including the message header). The variable size commands and command replies are affected by this limit. The old value (one page size minus the message header) won't allow us to read (or write) a whole page, which is a common use case, I guess. |
|
@adlazar can i merge this, or do you need more eyes/testing on it ? |
|
You can merge it, but you need it in userspace (libvmi) too. |
|
I forgot about this one, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to read a whole page with KVMI_READ_PHYSICAL.
Signed-off-by: Adalbert Lazăr [email protected]