Fixed some compatibility issues #286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compatibility with other planet mods. The previous version removes all the other celestial bodies. Newer version only removes stock celestial bodies.
altitude, maxAltitude, and atmosphereDepth can all set max atmosphere heights. The previous version can only apply to configs using maxAltitude, but if there are configs using altitude or atmosphereDepth, Module Manager errors will pop in. This new version fixes the issue and improves stability and compatibility.
|
The, uh, point of RSS is that it's the real solar system. It should by definition not be compatible with other planet packs, unless they explicitly are designed to add other real bodies (and in which case will know RSS is installed and can run AFTER[] the RSS pass). Other change seems fine. 👍 |
|
I understand your point. However, there are many people telling me they want to play my planet mod together with RSS, currently the only thing I can do is provide them with this version of config. I think it doesn't hurt to let people choose their mod selection, and these changes won't have any impact on either RSS or KSP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
altitude,maxAltitude, andatmosphereDepthcan all set max atmosphere heights. The previous version can only apply to configs usingmaxAltitude, but if there are configs usingaltitudeoratmosphereDepth, Module Manager errors will pop in. This new version fixes the issue and improves stability and compatibility.